Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: deprecation of containerArchitecture #1514

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Dec 18, 2022

This option isn't part of parsed docker cli flags of act.

Nobody protected me doing nonsense, I really expected that the --platform has been parsed.

Even if this flag has been parsed by docker options logic, this flag wouldn't be applied to docker_pull and other parts of act

@ChristopherHX ChristopherHX requested a review from a team as a code owner December 18, 2022 15:04
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ REPOSITORY gitleaks yes no 2.44s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.97s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #1514 (6b8ae87) into master (4f8da0a) will increase coverage by 3.71%.
The diff coverage is 67.39%.

@@            Coverage Diff             @@
##           master    #1514      +/-   ##
==========================================
+ Coverage   57.50%   61.22%   +3.71%     
==========================================
  Files          32       46      +14     
  Lines        4594     7141    +2547     
==========================================
+ Hits         2642     4372    +1730     
- Misses       1729     2462     +733     
- Partials      223      307      +84     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/parse_env_file.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 13.58% <11.48%> (+8.04%) ⬆️
pkg/model/workflow.go 42.11% <18.51%> (-8.80%) ⬇️
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@KnisterPeter KnisterPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody protected me doing nonsense, I really expected that the --platform has been parsed

Happens to all of us 😉. Don't want to name my previous failures here.

@mergify mergify bot merged commit 4989f44 into master Dec 19, 2022
@mergify mergify bot deleted the revert-deprecation-containerArchitecture branch December 19, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants