lgtm-cat-api 用の ECS を構築 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
force-pushed
the
feature/issue77/ecs-lgtm-cat-api
branch
from
6e1c380 to
deab441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#77
Doneの定義
#77 の完了条件を満たしていること
変更点概要
大きく以下の3つの変更を行った。
STGの設定のみ追加し、本番用の設定は別のPRで対応予定。
lgtm-cat-api 用の ECS を追加
ELBSecurityPolicy-TLS-1-2-Ext-2018-06を指定し、非推奨である TLS 1.0、1.1 は無効としたSTG lgtm-cat-api ECS から RDS に接続できるようにセキュリティグループのルールを追加
ECS に必要となる VPC エンドポイントを追加
com.amazonaws.region.ecr.dkr)com.amazonaws.region.ecr.api)補足情報
アプリケーション の変更は lgtm-cat-api https://github.com/nekochans/lgtm-cat-api/pull/75 で対応。