ランダムでLGTM画像を返すAPIに必要なLambdaの変更を行う #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
commented
Dec 18, 2021
Comment on lines
-20
to
-31
| statement { | ||
| effect = "Allow" | ||
| actions = [ | ||
| "logs:CreateLogGroup", | ||
| "logs:CreateLogStream", | ||
| "logs:PutLogEvents" | ||
| ] | ||
| resources = [ | ||
| "arn:aws:logs:*:*:*" | ||
| ] | ||
| } | ||
|
|
There was a problem hiding this comment.
AWSLambdaVPCAccessExecutionRole に含まれているため削除
kobayashi-m42
commented
Dec 18, 2021
| @@ -7,6 +7,8 @@ module "lambda" { | |||
| log_retention_in_days = local.log_retention_in_days | |||
| s3_bucket_name = data.terraform_remote_state.images.outputs.upload_images_bucket_name | |||
| lgtm_images_cdn_domain = data.terraform_remote_state.images.outputs.lgtm_images_cdn_domain | |||
| vpc_id = data.terraform_remote_state.network.outputs.vpc_id | |||
| subnet_ids = data.terraform_remote_state.network.outputs.subnet_public_ids | |||
There was a problem hiding this comment.
private subnet は構築していないので、public subnet に Lambda を構築
kobayashi-m42
commented
Dec 19, 2021
|
|
||
| resource "aws_iam_role_policy_attachment" "lambda_api_vpc_access_execution" { | ||
| role = aws_iam_role.lambda_api.name | ||
| policy_arn = "arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole" |
There was a problem hiding this comment.
Lambda がネットワークインターフェイスを作成および管理をできるように、実行ロールに AWSLambdaVPCAccessExecutionRoleを追加
参考：https://docs.aws.amazon.com/ja_jp/lambda/latest/dg/configuration-vpc.html#vpc-permissions
kobayashi-m42
force-pushed
the
feature/issue56/vpc-lambda
branch
from
aacbd9e to
b819075
Compare
keitakn
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#56
Doneの定義
#56 の完了条件が満たされていること
変更点概要
API Lambda から RDS と S3 にアクセスできるよう下記の変更を行なった
NAT gateway は構築していないので、VPC エンドポイントを利用して S3 にアクセスする
参考：VPC の Lambda 関数へのインターネットアクセスを許可する