STG環境用に RDS Proxy の認証を追加 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobayashi-m42
commented
Dec 11, 2021
| @@ -1,5 +1,5 @@ | |||
| resource "aws_secretsmanager_secret" "rds_connection" { | |||
| name = "${var.rds_name}/rds-connection" | |||
| name = "/prod/${var.rds_name}/rds-connection" | |||
There was a problem hiding this comment.
prod と stg を分ける必要があったので、名前を変更した
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#42
Doneの定義
変更点概要
STG環境用に RDS Proxy の認証を追加した。これによりSTG環境用のユーザで、RDSに接続できるようになる。
SecretManager の名前を命名規則に合わせてスネークケースからケバブケースに変更したので、data リソースで指定している name を修正。
SecretManager はAWSコンソールから手動で設定したもののため、今回もAWSコンソールから変更している。
補足
その他、STG環境の migration に必要となるリソースの作成は、別のPRで対応する。