アップロード機能に必要なS3バケットの作成と設定変更 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#18
Doneの定義
変更点概要
以下の2つのバケットを新規作成。
また、prod-lgtmeow-upload-images（今既にあるバケット）のバージョニング設定を無効化、これは一時的な画像には有効期限を持たせたいが、バージョニングが有効になっていると画像に有効期限を持たせられない為である。
レビュアーに重点的にチェックして欲しい点
Slackで相談した、S3バケットを分割する件 の対応なんだけど、問題ある場合は修正するから確認してもらえると:pray: