複数のFunction callingに対応出来る形に変更 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/infrastructure/repository/openai/openai_cat_message_repository.py:104: error: Item "None" of "list[ChatCompletionMessageToolCall] | None" has no attribute "__iter__" (not iterable) [union-attr] src/infrastructure/repository/openai/openai_cat_message_repository.py:123: error: Incompatible return value type (got "list[dict[str, str | Any] | ChatCompletionMessage | ChatCompletionSystemMessageParam | ChatCompletionUserMessageParam | ChatCompletionAssistantMessageParam | ChatCompletionToolMessageParam | ChatCompletionFunctionMessageParam]", expected "list[ChatCompletionSystemMessageParam | ChatCompletionUserMessageParam | ChatCompletionAssistantMessageParam | ChatCompletionToolMessageParam | ChatCompletionFunctionMessageParam]") [return-value] src/infrastructure/repository/openai/openai_cat_message_repository.py:128: error: Function is missing a return type annotation [no-untyped-def] Found 3 errors in 1 file (checked 33 source files)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#91
この PR で対応する範囲 / この PR で対応しない範囲
Function callingの複数呼び出しに対応出来るように改修を実施する
Storybook の URL、 スクリーンショット
なし
変更点概要
Function callingの複数呼び出しに対応出来るように
toolsを利用するように変更した。Function callingに現在時刻を返す関数を追加して問題なく動作する事を確認済。
複数箇所の天気も回答可能になっている。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
Functionの実行は順次実行なので呼び出し回数が多いとパフォーマンスに問題が出てくる可能性があるので、これは別のPRで対応する。