ユースケース、コントローラーのレスポンス型定義を collections.abc.AsyncIterator に変更 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keitakn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#99
この PR で対応する範囲 / この PR で対応しない範囲
#99 の完了の定義に記載されている通りユースケースのレスポンス型定義を
collections.abc.AsyncIteratorに変更する。Storybook の URL、 スクリーンショット
UI変更ではないのでなし
変更点概要
タイトルの通り。
元々ユースケースだけを対応する予定だったがコントローラー内の
StreamingResponseを生成している関数内でもジェネレータメソッドが利用されていたのでコントローラーでもAsyncIteratorを利用するようにした。レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし