Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change e in ISSM to 0.01. Add normalisation for ehs, add correct bins. #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mominno
Copy link

@Mominno Mominno commented Feb 29, 2024

I've found paper which mentions the mystery coeficient e. It's mentioned in Shnain, N.A., Hussain, Z.M., & Lu, S.F. (2017). A feature-based structural measure: An image similarity measure for face recognition [J].
(https://www.mdpi.com/2076-3417/7/8/786)

Its value is then equal to 0.01. I've also implemented changes for normalisation of the ehs and added argument for bins, since theoretically value space ranges from 0 to 255(without arg it defaults to 10, which gives skewed results).

Would be great if somebody could test it and verify this now works as intended. :]

Copy link
Owner

@nekhtiari nekhtiari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmigueldelgado jmigueldelgado self-requested a review May 16, 2024 07:20
@nekhtiari
Copy link
Owner

@jmigueldelgado can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants