Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add navigation #5

Merged
merged 15 commits into from
Aug 16, 2023
Merged

Add navigation #5

merged 15 commits into from
Aug 16, 2023

Conversation

nejidevelops
Copy link
Owner

In this PR, I have:

Here is a Demo of how the implemented features work:

Screencast.2023-08-16.10.12.14.mp4

Copy link

@ademibowale ademibowale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NewtonOmbese ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight 💯

  • No linters errors ✔️
  • Descriptive pull request ✔️
  • website consisting of 3 pages: Home, Calculator, and Quote✔️
  • Navigation links for all three routes are displayed on each page.✔️
  • general layout match the given wireframes in the project requirements✔️
  • Descriptive commit messages ✔️
  • Good use of Github flow ✔️

  • Please check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me on( @Adebowale ) in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@nejidevelops nejidevelops merged commit 010a77a into develop Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants