Add popup menu #67
Closed
Add popup menu #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,13 @@ The implementation of `NADotAnnotation` places a red semi-transparent dot on the | |||
|
|
|||
| You can find a complete custom annotation example of multi-colored pins in [NAPinAnnotation.h](NAMapKit/NAPinAnnotation.h)/[.m](NAMapKit/NAPinAnnotation.m). | |||
|
|
|||
| ####Circle popup menu | |||
There was a problem hiding this comment.
I think this should just be added to above, just like we say "you can find a complete custom annotation example in " maybe say "another example of ... can be found in". Make sure to link the source files.
|
Can you please update https://github.com/neilang/NAMapKit/blob/master/CHANGELOG.md, just say that you've added an example that does XYZ. Squash your commits if you don't mind, I'll merge this after, looks great. Thanks for hanging in here! |
|
The |
|
Merged via b3b7987, nice job! |
|
Thanks! |
|
👍 closing as merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the popup menu into the demo application, the document have updated, please reference the section
Circle popup menu.Thanks!