Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupled map view with and without annotations, added tests. #16

Merged
merged 11 commits into from
Mar 9, 2014
Merged

Decoupled map view with and without annotations, added tests. #16

merged 11 commits into from
Mar 9, 2014

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Mar 9, 2014

This is prep work for #13, we want to simplify the map view and annotation interface, and give the annotation view to the annotation to deal with fully.

  • Tests that load the various demo project items (menu, and each map) and compare snapshotted images of those. Uses https://github.com/dblock/ios-snapshot-test-case-expecta.
  • Split NAMapView into an NAMapView and NAPinAnnotationMapView, we want pins to be a minimal interface that is basically a point and a view, and you can implement more complex scenarios like the one where a pin has a callout in subclasses. I am totally open for a discussion on what those base interfaces should look like - we can get this right now.
  • Annotations mostly take care of themselves now. A lot of pin annotation logic has moved into the child NAPinAnnotation and NAPinAnnotationView.
  • The interface around observing size changes is clearer, annotation views no longer have to observe size changes.
  • Fixed iOS deprecation warnings.
  • Wrote some README explanations on how to use NAMapKit.

@dblock
Copy link
Collaborator Author

dblock commented Mar 9, 2014

cc: @orta and @robb, you guys know this codebase well, would appreciate a review of these, too

break;
case 1:
cell.textLabel.text = @"Load via NIB demo";
cell.textLabel.text = @"Basic demo";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terminology is a bit confusing here, plain & basic to me are pretty much the same.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am renaming the first one to "NAAnnotation Demo" and the second one to "NAPinAnnotation Demo", which is what these are.

neilang added a commit that referenced this pull request Mar 9, 2014
Decoupled map view with and without annotations, added tests.
@neilang neilang merged commit 728fb84 into neilang:version-3.0 Mar 9, 2014
@neilang
Copy link
Owner

neilang commented Mar 9, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants