-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupled map view with and without annotations, added tests. #16
Conversation
break; | ||
case 1: | ||
cell.textLabel.text = @"Load via NIB demo"; | ||
cell.textLabel.text = @"Basic demo"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terminology is a bit confusing here, plain & basic to me are pretty much the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am renaming the first one to "NAAnnotation Demo" and the second one to "NAPinAnnotation Demo", which is what these are.
Decoupled map view with and without annotations, added tests.
Thanks! |
This is prep work for #13, we want to simplify the map view and annotation interface, and give the annotation view to the annotation to deal with fully.
NAMapView
into anNAMapView
andNAPinAnnotationMapView
, we want pins to be a minimal interface that is basically a point and a view, and you can implement more complex scenarios like the one where a pin has a callout in subclasses. I am totally open for a discussion on what those base interfaces should look like - we can get this right now.NAPinAnnotation
andNAPinAnnotationView
.NAMapKit
.