Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2 multi packages #3

Merged
merged 31 commits into from
Sep 2, 2023
Merged

Feature/2 multi packages #3

merged 31 commits into from
Sep 2, 2023

Conversation

pospi
Copy link
Collaborator

@pospi pospi commented Aug 29, 2023

resolves #2

The storybook config seemed to be brittle. Never got it working even before I started refactoring. So have updated that toolchain.

Some things I'd like to clean up / fix (but please feel free if you'd like to take over)

  • I think ScopedElementRegistry needs to be injected into Storybook somehow 'cos nothing renders
  • individual component exports need to be tested (i.e. importing sub-paths)
  • I'm not that familiar with https://www.typescriptlang.org/docs/handbook/project-references.html so have removed that to get things running. @nick-stebbings may want to restore it, as well as setting up some useful inheritance for tsconfig.json with extends so that the two configs under each package are no longer duplicated.

Created additional issues for the crossed out items above. #5 , #6

@pospi pospi added the enhancement New feature or request label Aug 29, 2023
@pospi pospi self-assigned this Aug 29, 2023
@pospi
Copy link
Collaborator Author

pospi commented Aug 31, 2023

@nick-stebbings I made good progress with this today- CustomElements turned out to be a little complicated to fix, including changing the Shoelace lib being used. The components are now rendering but some look a little visually weird and I think I'd have to hand over to you in order to know what is left to clean up there. Hopefully just missing styles. Some other polish one of us may want to do in tying this off:

  • finish importing fonts (I made a start on Manrope but the others are still missing). This includes ensuring the CSS is setup in a browser-compatible way.
  • inject styling into the Storybook rendering so that all components render against the standard NHs background colour

@nick-stebbings
Copy link
Contributor

Great @pospi I will look over it and review tomorrow morning. I am working this weekend a bit, think you said you also were so we might be able to get it all tied up.

I posted re: the fonts stuff on discord but not sure you saw it. It can be imported from the styles package.

@nick-stebbings nick-stebbings marked this pull request as ready for review September 2, 2023 00:20
@adaburrows adaburrows merged commit 6dc4b80 into main Sep 2, 2023
@adaburrows adaburrows deleted the feature/2-multi-packages branch September 2, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Setup build system for multiple packages
3 participants