Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5 tsbuild config #11

Merged
merged 24 commits into from
Sep 6, 2023
Merged

Feature/5 tsbuild config #11

merged 24 commits into from
Sep 6, 2023

Conversation

pospi
Copy link
Collaborator

@pospi pospi commented Sep 5, 2023

Implements #5.

@pospi pospi added the enhancement New feature or request label Sep 5, 2023
@pospi pospi requested a review from nick-stebbings September 5, 2023 01:38
@pospi pospi self-assigned this Sep 5, 2023
…fig files for independent build mode to avoid incompatibilities between Storybook bundling & TS compiler behaviour.
@pospi pospi marked this pull request as ready for review September 5, 2023 02:50
@pospi pospi requested a review from weswalla September 5, 2023 02:50
@pospi
Copy link
Collaborator Author

pospi commented Sep 5, 2023

This'll do 😜 documentation incoming...

Copy link
Contributor

@nick-stebbings nick-stebbings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great job.
Looks very well organised. I tested the build and everything is running smoothly. Haven't yet got imports working when linking locally to the monorepo from the launcher though. Any tips?
[commonjs--resolver] Failed to resolve entry for package "@neighbourhoods/design-system-components". The package may have incorrect main/module/exports specified in its package.json. error during build: Error: Failed to resolve entry for package "@neighbourhoods/design-system-components". The package may have incorrect main/module/exports specified in its package.json.

Copy link
Contributor

@nick-stebbings nick-stebbings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thanks for the docs! Very helpful.

@pospi pospi merged commit 5fff838 into main Sep 6, 2023
@pospi pospi deleted the feature/5-tsbuild-config branch September 6, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants