Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always output TOTAL line. #1091

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

lordjabez
Copy link
Contributor

Always output the TOTAL line, and update tests to match new functionality.

Copy link

@portante portante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW ...

coverage/summary.py Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
tests/test_process.py Outdated Show resolved Hide resolved
@nedbat
Copy link
Owner

nedbat commented Jan 6, 2021

This is great, thanks. A little more detail in the changelog, and remove an unneeded string formatting, and we are ready to merge!

@codecov-io
Copy link

Codecov Report

Merging #1091 (7b083fb) into master (7ff93a9) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   91.28%   91.22%   -0.07%     
==========================================
  Files          90       90              
  Lines       13358    13361       +3     
  Branches     1493     1493              
==========================================
- Hits        12194    12188       -6     
- Misses        953      959       +6     
- Partials      211      214       +3     
Impacted Files Coverage Δ
tests/test_plugins.py 96.56% <ø> (ø)
coverage/summary.py 88.07% <100.00%> (ø)
tests/test_api.py 93.00% <100.00%> (-0.42%) ⬇️
tests/test_concurrency.py 86.31% <100.00%> (ø)
tests/test_process.py 86.33% <100.00%> (ø)
tests/test_summary.py 93.34% <100.00%> (+0.04%) ⬆️
tests/test_oddball.py 81.54% <0.00%> (-1.20%) ⬇️
coverage/control.py 90.10% <0.00%> (-1.05%) ⬇️
coverage/collector.py 61.97% <0.00%> (-0.47%) ⬇️
... and 1 more

@nedbat
Copy link
Owner

nedbat commented Jan 6, 2021

@lordjabez Thanks. I see now that I misread the os.sep string formatting, thanks for putting up with me :) I will merge this when the tests pass.

@nedbat nedbat merged commit 051bdf2 into nedbat:master Jan 6, 2021
@lordjabez lordjabez deleted the feature/show-total-line branch January 6, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants