-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always output TOTAL line. #1091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW ...
3cd2c76
to
7b083fb
Compare
This is great, thanks. A little more detail in the changelog, and remove an unneeded string formatting, and we are ready to merge! |
7b083fb
to
6a9dfa3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
==========================================
- Coverage 91.28% 91.22% -0.07%
==========================================
Files 90 90
Lines 13358 13361 +3
Branches 1493 1493
==========================================
- Hits 12194 12188 -6
- Misses 953 959 +6
- Partials 211 214 +3
|
6a9dfa3
to
5f0594b
Compare
@lordjabez Thanks. I see now that I misread the os.sep string formatting, thanks for putting up with me :) I will merge this when the tests pass. |
Always output the TOTAL line, and update tests to match new functionality.