Revert changed address factory #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In solidusio/solidus#3584, they changed the address factory [1], so the firstname and lastname will differ from the previous version. This commits reverts the changes, so if in your applications test you're using the old address factory, the specs will continue to work properly. 1: https://github.com/solidusio/solidus/pull/3584/files#diff-8e88fbe32e58692ffaf3629a7fdfdadfa4378dd248a011fc8d2d266a5ed299a4
MassimilianoLattanzio
requested review from
DanielePalombo,
abhishekgupta5 and
piyushswain
DanielePalombo
approved these changes
Aug 11, 2023
Yeah, I have to do something similar in my project, so I directly added these changes in the extension. Unless you require this factory from the extension, this PR doesn't affect you. But probably it's better to test it with your changes. When you have some time, please try this PR in your project and let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In solidusio/solidus#3584, they changed the address factory, so the
firstnameandlastnamewill differ from the previous version.This commits reverts the changes, so if in your applications test you're using the old address factory, the specs will continue to work properly.