docs(README): deploy slurm cluster in a namespace aligned with the cluster name #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rest.RenderSecret renders the cluster name as the namespace Signed-off-by: Luo Jian <[email protected]>
CrackedPoly
requested review from
dstaroff,
asteny,
rdjjke and
Uburro
as code owners
asteny
approved these changes
Nov 18, 2024
rdjjke
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rest.RenderSecret renders the cluster name as the namespace. This should be explicit in the README.
soperator/internal/controller/clustercontroller/common.go
Line 55 in 8766049