Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabled support for probe mapping and max31865 #72

Merged

Conversation

lausdahl
Copy link
Contributor

This adds support for probe mapping and a new type max31865. While I didnt touch any of the control code this simply allows the user to configure the systems 3 types: Grill, Probe1, Probe2. The default mapping is:

System                   Source
------------------------
Grill        <-      ADC0
Probe1       <-      ADC1
Probe2       <-      ADC2
-------------------------

alternative it can be configured like switching the ADC index between Grill and Probe2

System                   Source
------------------------
Grill         <-      ADC2
Probe1        <-      ADC1
Probe2        <-      ADC0
-------------------------

however the reason for adding the mapping is to allow other sources

System                   Source
------------------------
Grill        <-      max31865
Probe1       <-      ADC1
Probe2       <-      ADC2
-------------------------

The max31865 driver is set to spi device 2.

If this is merged it may be worth simplifying the ADC driver to just use ADC0-3 when reporting the values.

settings looks like this if max31865 is used for grill

  "probe_settings": {
    ....
    "probes_enabled": [
      1,
      1,
      1
    ],
    "probe_sources": ["max31865","ADC1","ADC2"]
  },
...

@nebhead
Copy link
Owner

nebhead commented Jan 15, 2022

This is an awesome change, thank you for submitting the pull request! The max31865 has been a requested feature for a while, but I hadn't gotten around to purchasing one to play with. So thank you again for this! Also, this is great solution to re-map the inputs. I think this would be good for expanding to more input sources as well.

@nebhead nebhead merged commit 460e410 into nebhead:development Jan 15, 2022
@lausdahl lausdahl deleted the probe_mapping_support_max31865 branch January 15, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants