-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support updated kubespawner #2938
base: main
Are you sure you want to change the base?
Conversation
envvars_fixed = {**(profile["kubespawner_override"].get("environment", {}))} | ||
|
||
def preserve_envvars(spawner): | ||
# This adds in JUPYTERHUB_ANYONE/GROUP rather than overwrite all env vars, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior of Kubespawner changed in v5 so kubespawner_override's default behavior is merge instead of replace now so I'm now simplifing this part.
reference: https://jupyterhub-kubespawner.readthedocs.io/en/latest/changelog.html#id24
|
||
return profile | ||
|
||
|
||
@gen.coroutine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flyby: tornado coroutine to native coroutine
Failing tests should be able to be rerun. I'm seeing |
"Local Integration Tests" will fail until nebari-dev/nebari-docker-images#194 is merged |
I tested this locally and Local Integration tests passed fine. I changed the jupyterhub image to the one created by the CI in nebari-dev/nebari-docker-images#194 in 5829038. We should revert 5829038 prior to merging, but it'll show reviewers that the tests pass first. |
Reference Issues or PRs
Necessary changes to support Kubespawner >= 5.0.0
Should be merged simultaneously with nebari-dev/nebari-docker-images#194
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
When using the
quay.io/nebari/nebari-jupyterhub:jhub-fancy-profiles-df68a39-20250204
for my jupyterhub image I got errors when loading the profile_list of servers to start up, but this PR resolves them, and I can now start a server successfully with Kubespawner version 6.2.Any other comments?