Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support updated kubespawner #2938

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

support updated kubespawner #2938

wants to merge 5 commits into from

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Feb 5, 2025

Reference Issues or PRs

Necessary changes to support Kubespawner >= 5.0.0
Should be merged simultaneously with nebari-dev/nebari-docker-images#194

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): Update dependencies

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

When using the quay.io/nebari/nebari-jupyterhub:jhub-fancy-profiles-df68a39-20250204 for my jupyterhub image I got errors when loading the profile_list of servers to start up, but this PR resolves them, and I can now start a server successfully with Kubespawner version 6.2.

Any other comments?

envvars_fixed = {**(profile["kubespawner_override"].get("environment", {}))}

def preserve_envvars(spawner):
# This adds in JUPYTERHUB_ANYONE/GROUP rather than overwrite all env vars,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior of Kubespawner changed in v5 so kubespawner_override's default behavior is merge instead of replace now so I'm now simplifing this part.
reference: https://jupyterhub-kubespawner.readthedocs.io/en/latest/changelog.html#id24


return profile


@gen.coroutine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby: tornado coroutine to native coroutine

@Adam-D-Lewis
Copy link
Member Author

Failing tests should be able to be rerun. I'm seeing Github rate-limiter failed the request. Either authenticate or wait a couple of minutes. in failing test output.

@dcmcand dcmcand requested a review from a team as a code owner February 7, 2025 14:18
@Adam-D-Lewis
Copy link
Member Author

"Local Integration Tests" will fail until nebari-dev/nebari-docker-images#194 is merged

@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Feb 10, 2025

I tested this locally and Local Integration tests passed fine. I changed the jupyterhub image to the one created by the CI in nebari-dev/nebari-docker-images#194 in 5829038. We should revert 5829038 prior to merging, but it'll show reviewers that the tests pass first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

2 participants