Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump env-schema from 5.1.0 to 5.1.1 #682

Merged
merged 2 commits into from
Nov 17, 2022
Merged

build(deps): bump env-schema from 5.1.0 to 5.1.1 #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c530082
build(deps): bump env-schema from 5.1.0 to 5.1.1
dependabot[bot] Nov 17, 2022
8fad172
fix: typing in typescript step schema fixed
Ceres6 Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"@slidev/cli": "^0.36.11",
"@vueuse/shared": "^9.5.0",
"desm": "^1.3.0",
"env-schema": "^5.1.0",
"env-schema": "^5.1.1",
"fastify": "^4.10.0",
"fluent-json-schema": "^4.0.0",
"http-errors": "^2.0.0",
Expand Down
1 change: 1 addition & 0 deletions src/step-14-typescript/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const schema = S.object()
.prop('JWT_SECRET', S.string().required())
.prop('LOG_LEVEL', S.string().default('info'))
.prop('PRETTY_PRINT', S.string().default(true))
.valueOf()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this change is not needed in all the other config.js files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it just have to do with typing. It was removed in fastify/env-schema#137. Another option would be to have this as any or to have another typescript workaround, but this seemed cleaner to me. I have opened an issue in fastify/env-schema#138 to get a proper solution


export default envSchema<EnvConfig>({
schema,
Expand Down