-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for windows #1132
CI for windows #1132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to have a dedicated workflow. see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#using-a-github-hosted-runner
Yep, just testing if Github now supports running window containers. We have DB dependent tests so this was for that. Will merge with the original CI file once done |
oh ok I see that and I wasn't aware that containers were not supported. if that is the case, we can do without windows support then |
thoughts on forking the action being used vs helping the author maintain it? |
why would we need to fork the action? |
Closes #1131