Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for windows #1132

Merged
merged 11 commits into from
Feb 2, 2024
Merged

CI for windows #1132

merged 11 commits into from
Feb 2, 2024

Conversation

barelyhuman
Copy link
Contributor

Closes #1131

@barelyhuman barelyhuman added the github_actions Pull requests that update Github_actions code label Feb 1, 2024
@barelyhuman barelyhuman self-assigned this Feb 1, 2024
@barelyhuman barelyhuman marked this pull request as draft February 1, 2024 14:19
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barelyhuman
Copy link
Contributor Author

no need to have a dedicated workflow. see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#using-a-github-hosted-runner

Yep, just testing if Github now supports running window containers. We have DB dependent tests so this was for that. Will merge with the original CI file once done

@simoneb
Copy link
Member

simoneb commented Feb 1, 2024

oh ok I see that and I wasn't aware that containers were not supported. if that is the case, we can do without windows support then

@barelyhuman barelyhuman marked this pull request as ready for review February 2, 2024 08:51
@barelyhuman
Copy link
Contributor Author

thoughts on forking the action being used vs helping the author maintain it?

@barelyhuman barelyhuman requested a review from simoneb February 2, 2024 08:52
@simoneb
Copy link
Member

simoneb commented Feb 2, 2024

why would we need to fork the action?

@barelyhuman barelyhuman merged commit 69216c8 into master Feb 2, 2024
4 checks passed
@barelyhuman barelyhuman deleted the ci/add-windows branch February 2, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Add a way to test on windows
2 participants