-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add set_system_time function #32
Conversation
Hi @paolochiodi I've tried to implement the requested missing feature. Could you please take a look if I'm heading in the right direction? Thanks. |
@paolochiodi can you please take a look at this PR? we forgot about it |
Nice missing feature. I would suggest to use datetime format It would be also nice to have timezone support (as in original support) but this will be more work to be done as |
@dzolo thanks for the suggestion, adding ms portion to the timestamp is not a bad idea. I will update the date/time format. Regarding the Timezone support - would be a nice addition, however, I would probably open a feature request issue and that can be tackled in a separate PR, in order not to make this PR more complex than it needs to be. |
Support for milliseconds and microseconds added. They are both optional. @dzolo a review of the PR would be appreciated 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of comments but overall LGTM, nice job 👌
Closes #31
I've added a new file with
set_system_time
function that will set a configuration parameter on the db calleduser_defined.system_time
and fill in the desired value. Theversioning
function will then try to use this config parameter to set thetime_stamp_to_use
.versioning_function
andversioning_function_no_checks
too use the new config parameter ✅