Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a test case for tables in CamelCase #17

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

yktv4
Copy link
Contributor

@yktv4 yktv4 commented Jan 5, 2020

I decided to remove all unnecessary quote_ident usages in the procedure. Since the fix is not backwards compatible, according to https://semver.org, I needed to also bump the first non-zero character in the version, hence the new version is 0.3.0.

See my motivation in #16 .

@paolochiodi
Copy link
Member

Hi,
thanks for taking the time to provide this PR.

I like your clean solution and think that indeed asking the developer to provided a properly quoted and escaped table name is the best solution.

I've created a new PR incorporating your changes here: #21 because I:

  • needed to solve some conflicts
  • wanted to change the name of the tests to upper_case, as this is not specific to camelCase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants