Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add TypeScript support to eslint #288

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Fix: add TypeScript support to eslint #288

merged 7 commits into from
Jan 9, 2024

Conversation

andreaforni
Copy link
Contributor

@andreaforni andreaforni commented Jan 9, 2024 •
edited
Loading

Closes #289

ESLint was not linting TypeScript files, only JavaScript ones.

This PR:

  • Adds TypeScript linting support.
  • Adds new script: lint:fix to automatically fix linting problems.
  • Updates the lint-staged command to lint TypeScript files too.
  • Fixes all the lint issues (for this reason, you see a lot of changes).

@andreaforni andreaforni marked this pull request as ready for review January 9, 2024 10:48
review-bot-for-github[bot]
review-bot-for-github bot reviewed Jan 9, 2024
View reviewed changes
Copy link

@review-bot-for-github review-bot-for-github bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments.

simoneb
simoneb reviewed Jan 9, 2024
View reviewed changes
package.json Show resolved Hide resolved
marceloFerreira90
marceloFerreira90 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@marceloFerreira90 marceloFerreira90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marceloFerreira90 marceloFerreira90 merged commit 28e47ec into main Jan 9, 2024
3 of 5 checks passed
@marceloFerreira90 marceloFerreira90 deleted the fix/add-ts-eslint branch January 9, 2024 12:55
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@review-bot-for-github review-bot-for-github[bot] review-bot-for-github[bot] left review comments

@simoneb simoneb simoneb left review comments

@marceloFerreira90 marceloFerreira90 marceloFerreira90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint does not lint TypeScript files
3 participants
@andreaforni @simoneb @marceloFerreira90