Add base functionality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
paolochiodi
commented
Oct 15, 2020
•
paolochiodi
commented
- code extracted from Fastify secrets titus#546
- add tests
- linting
- README
- CI Workflow
- parallel calls to client.get
paolochiodi
force-pushed
the
feature/base-functionality
branch
from
7919e84 to
600ed18
Compare
mcollina
suggested changes
Oct 15, 2020
lib/build-plugin.js
Outdated
| const fp = require('fastify-plugin') | ||
| const pProps = require('p-props') | ||
|
|
||
| const GET_CONCURRENCY = 5 |
There was a problem hiding this comment.
this should be an option on the plugin
Co-authored-by: Matteo Collina <[email protected]>
…ify-secrets-core into feature/base-functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.