Add onAllow callback support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 37 39 +2
=========================================
+ Hits 37 39 +2
Continue to review full report at Codecov.
|
kibertoad
commented
Apr 20, 2021
| return await options.onDeny(reply, { sub, dom, obj, act }) | ||
| } | ||
|
|
||
| if (options.onAllow) { |
There was a problem hiding this comment.
I believe that executing this conditionally should be faster for noop cases than invoking an empty function always, but I'm happy to change to always executing an empty function by default if you prefer that approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to use this callback for audit purposes. We already can log failures using onDeny, but successful access is tricky currently.