Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for generics in extractor definition #13

Merged
merged 1 commit into from
Jan 17, 2021

Conversation

kibertoad
Copy link
Contributor

Previously generics were ignored inside extractors that made using them in type-safe way a huge hassle.
This makes extractor definitions respect generics specified for the route.

@codecov-io
Copy link

Codecov Report

Merging #13 (144f61d) into master (8ca51f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           34        34           
=========================================
  Hits            34        34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca51f0...144f61d. Read the comment docs.

@simoneb simoneb merged commit fe4eaa5 into nearform:master Jan 17, 2021
@kibertoad kibertoad deleted the fix/request-generics branch January 17, 2021 21:46
@kibertoad
Copy link
Contributor Author

@simoneb My apologies for a barrage of requests, but if you could release a new version whenever you have some free time, that would be appreciated! Sorry that new issues keep coming up, still fleshing out our pilot implementation.

@simoneb
Copy link
Member

simoneb commented Jan 18, 2021

1.2.1 contains this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants