Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constants instead of extractors #12

Merged
merged 3 commits into from
Jan 16, 2021

Conversation

kibertoad
Copy link
Contributor

Considering that in many cases we know which entity and which operation is the endpoint handling, passing whole function can be redundant.

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #12 (0abca3c) into master (ebd666d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           28        34    +6     
=========================================
+ Hits            28        34    +6     
Impacted Files Coverage Δ
plugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd666d...0abca3c. Read the comment docs.

@simoneb simoneb merged commit b2d386b into nearform:master Jan 16, 2021
@kibertoad kibertoad deleted the feature/support-constants branch January 16, 2021 23:23
@kibertoad
Copy link
Contributor Author

@simoneb Thank you! Any chance you could release a new version?

@simoneb
Copy link
Member

simoneb commented Jan 16, 2021

1.2.0 is out

@kibertoad
Copy link
Contributor Author

@simoneb Yay! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants