Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying custom logger #11

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

kibertoad
Copy link
Contributor

fixes #7

Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please fix the failing test? It's due to CI getting a new version of fastify containing this change.

@kibertoad
Copy link
Contributor Author

@simoneb Sure, give me a sec.

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #11 (8c3c5de) into master (e8febb4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           26        28    +2     
=========================================
+ Hits            26        28    +2     
Impacted Files Coverage Δ
plugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8febb4...8c3c5de. Read the comment docs.

@simoneb simoneb merged commit ebd666d into nearform:master Jan 16, 2021
@kibertoad kibertoad deleted the feature/custom-log branch January 16, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom enforce loggers
3 participants