Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make husky script executable #130

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

simoneb
Copy link
Member

@simoneb simoneb commented Dec 18, 2021

No description provided.

@simoneb
Copy link
Member Author

simoneb commented Dec 18, 2021

@Eomm mentioning you just for your information. Running npm ci in the release automation may not be the safest option. It's not very explicit either. In this case for example the precommit husky script was not executable (which is a problem in itself already). We should consider making it more explicit nonetheless, for instance run npm run build instead

@simoneb simoneb merged commit 5e5c3fa into main Dec 18, 2021
@simoneb simoneb deleted the chore/make-husky-script-executable branch December 18, 2021 17:23
@github-actions github-actions bot mentioned this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant