fix: removed overwritting of indexername in obj #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darunrs
reviewed
Jul 31, 2024
| @@ -158,7 +158,6 @@ const fetchIndexerMetadata = () => { | |||
| original_deployment_date | |||
| }) => { | |||
| const indexer = { | |||
| accountId: indexer_account_id, | |||
| indexerName: indexer_name, | |||
darunrs
approved these changes
Jul 31, 2024
…ttps://github.com/near/queryapi into 961-indexer-name-is-served-incorrectly-to-the-url
Kevin101Zhang
deleted the
961-indexer-name-is-served-incorrectly-to-the-url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Databricks stores account and function names in their sanitized form (Only alphanumerics and underscores) as this is how they are stored in Hasura. However, the actual indexer and accounts are stored in both RPC and the queryapi_indexer under their original names.
This PR prevents the metadata from databricks overwriting the original names with the sanitized ones.