Use new Metadata Table for status and block height #676
Conversation
|
Query needs to be renamed after creating new metadata table. Existing metadata and logs tables are prepended with double underscores, which are reserved by graphQL. The tables need to be renamed. Will merge this when the new tables are prepared. |
| current_block_height | ||
| current_historical_block_height | ||
| const Status = ({ accountId, functionName, latestHeight }) => { | ||
| const hasuraRole = accountId.replace(/[^a-zA-Z0-9]/g, '_'); // TODO: Support accounts that start with a number |
There was a problem hiding this comment.
Can we support this TODO now? Implicit accounts are likely to start with numbers
There was a problem hiding this comment.
Sure I can add the fix in for it now. I'll do so partially for now. The second part of this is quoting database names from now on. If a database or schema is created with a capital letter, it will fail if a similar name without capital letters was already created. For example, if you tried to provision an indexer as Morgs.near, the DB will be created correctly, and a schema will too, albeit with lowercase name. But the tables will fail to create. I'll support that separately. It needs more strict testing to ensure backwards compatibility.
darunrs
force-pushed
the
use-metadata-table-frontend
branch
from
d069c4c to
67cfdfa
Compare
| @@ -12,9 +12,9 @@ First, download the bos-loader cli by following this guide [here](https://docs.n | |||
| From the root of QueryAPI Frontend repo, run the following command | |||
|
|
|||
| ```bash | |||
| yarn serve:widgets:local // for running local enviornment | |||
There was a problem hiding this comment.
Since we removed the yarn file from Runner, we should do the same for frontend too. I checked and we do not use any yarn commands in the deployment of frontend in Terraform. Deleting yarn.lock for the same reason.
| @@ -54,11 +54,12 @@ | |||
| "@opentelemetry/api": "^1.8.0", | |||
| "@opentelemetry/exporter-zipkin": "^1.22.0", | |||
| "@opentelemetry/resources": "^1.22.0", | |||
| "@opentelemetry/sdk-node": "^0.49.1", | |||
| "@opentelemetry/sdk-node": "^0.50.0", | |||
There was a problem hiding this comment.
Needed to bump version as I was getting some type mismatch errors in IDE.
| "@opentelemetry/sdk-trace-base": "^1.22.0", | ||
| "@opentelemetry/sdk-trace-node": "^1.22.0", | ||
| "@opentelemetry/semantic-conventions": "^1.22.0", | ||
| "express": "^4.18.2", | ||
| "graphql": "^16.8.1", |
There was a problem hiding this comment.
Apparently we were using this package as a dependency in import { gql, GraphQLClient } from 'graphql-request'; in integration tests, but it wasn't automatically added through install.
| .vscode/ | ||
| */yarn.lock |
There was a problem hiding this comment.
There are mainly for convenience. .vscode folder is necessary for the IDE to work right, and I'm ignoring yarn.lock files to prevent publishing of them again in the future.
| overlay={<Tooltip> { | ||
| attributeMap.get("LAST_PROCESSED_BLOCK_HEIGHT") | ||
| ? `Current Block Height of Near is ${latestHeight}. Your indexer has a gap of ${latestHeight - attributeMap.get("LAST_PROCESSED_BLOCK_HEIGHT")} Blocks` | ||
| : 'Indexer needs to run successfully to update block height' } </Tooltip>} |
There was a problem hiding this comment.
It is possible now for failing indexers to not have a last processed block as they haven't successfully processed a block since the new table was rolled out.
We only set the height after a successful run. I have a custom message for this case.
Frontend now queries the new metadata table instead of the old one.
Indexers which have not successfully run since the introduction of the new logs table will not have a last processed block height since they never processed a block successfully. So, I opted to set it as N/A and leave a tooltip on hover which says why its N/A.
