Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve Proto File Not Found Build Error #514

Merged
merged 3 commits into from
Jan 17, 2024
+4 −5
Merged

fix: Resolve Proto File Not Found Build Error #514

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68bcc5e
fix: Add Proto file to Docker
darunrs Jan 17, 2024
2561c9b
fix: Resolve BUild Error for Proto File
darunrs Jan 17, 2024
3a927cd
fix: Renaming env variable to be more descriptive
darunrs Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
fix: Resolve BUild Error for Proto File
@darunrs
darunrs committed Jan 17, 2024
commit 2561c9babfb6cf25aaef464163864ee8d39c7676
1 change: 0 additions & 1 deletion docker-compose.yml
View file
Original file line number Diff line number Diff line change
@@ -42,7 +42,6 @@ services:
PORT: 9180
AWS_ACCESS_KEY_ID:
AWS_SECRET_ACCESS_KEY:
RUNNER_HOST: localhost
RUNNER_PORT: 7001

redis:
3 changes: 1 addition & 2 deletions runner/src/server/runner-server.ts
View file
Original file line number Diff line number Diff line change
@@ -17,11 +17,10 @@ export default function startRunnerServer (executors: Map<string, StreamHandler>
server.addService(runnerProto.runner.Runner.service, getRunnerService(executors));
const credentials = grpc.ServerCredentials;

assert(process.env.RUNNER_HOST, 'RUNNER_HOST is not defined');
assert(process.env.RUNNER_PORT, 'RUNNER_PORT is not defined');

server.bindAsync(
`${process.env.RUNNER_HOST}:${process.env.RUNNER_PORT}`,
`localhost:${process.env.RUNNER_PORT}`,
credentials.createInsecure(), // TODO: Use secure credentials with allow for Coordinator
(err: Error | null, port: number) => {
if (err) {