rust: 1.68.2 -> 1.69.0 #8937
Merged
rust: 1.68.2 -> 1.69.0 #8937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to this long awaited nice version that just so happened to have been released on a particularly well timed occassion.
|
Oh, this will be all sorts of fun! |
nagisa
force-pushed
the
nagisa/rust-1.69.0
branch
from
a85eb60 to
6a95b5d
Compare
These don't appear to be doing much in terms of useful and now that the compiler is more stringent in testing what `#[proc_macro_attribute]` is allowed to take as an argument these are broken too without more intense changes.
|
The test failure is clap-rs/clap#4857. The best way forward, I think, is to upgrade clap. |
Ekleog-NEAR
reviewed
Apr 26, 2023
| 10913823971520273759, | ||
| 17423008210698923502, | ||
| 7011050181604188333, | ||
| 15514788595649734538, |
There was a problem hiding this comment.
Hmm I’m curious, do you know why the hashes changed? I wouldn’t expect a rustc upgrade to change the hashes of wasmer binaries
There was a problem hiding this comment.
rkyv is sensitive to repr(Rust) layout changes, unless the strict feature is enabled. Unfortunately that is something we cannot enable as we rely on being able to serialize tuples, and tuples are repr(Rust). So something about how stuff is laid out there has changed.
|
Blocked on #8974 |
nikurt
approved these changes
Apr 28, 2023
jakmeier
pushed a commit
to jakmeier/nearcore
that referenced
this pull request
May 8, 2023
Upgrade to this long awaited nice version that just so happened to have been released on a particularly well timed occassion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to this long awaited nice version that just so happened to have been released on a particularly well timed occassion.