fix: make sure that cargo test can be killed with ctrl+c
#6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure why we were catching ctrl+c in the first place. This was introduced in near#4229 I think. But messing up with signal handlers in tests doesn't feel right and, indeed, prevents tests from being killed. Test Plan --------- Manual testing: running `cargo t -p integration-tests` and then killing it in the middle with ctrl+c leaves the test running in the background before this PR, and properly kills the process after.
mina86
approved these changes
May 13, 2022
nikurt
pushed a commit
that referenced
this pull request
May 17, 2022
I am not sure why we were catching ctrl+c in the first place. This was introduced in #4229 I think. But messing up with signal handlers in tests doesn't feel right and, indeed, prevents tests from being killed. Test Plan --------- Manual testing: running `cargo t -p integration-tests` and then killing it in the middle with ctrl+c leaves the test running in the background before this PR, and properly kills the process after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure why we were catching ctrl+c in the first place. This was
introduced in #4229 I think. But messing up with signal handlers in
tests doesn't feel right and, indeed, prevents tests from being killed.
Test Plan
Manual testing: running
cargo t -p integration-testsand then killingit in the middle with ctrl+c leaves the test running in the background
before this PR, and properly kills the process after.