nit(runtime): drop serde Serialize and Deserialize for VMOutcome #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
requested review from
bowenwang1996,
EgorKulikov,
matklad,
mzhangmzz and
olonho
as code owners
4 tasks
|
Looks like master "cargo check nearcore library" is fail on building openssl-sys v0.9.70, which cause the same ci failure here |
|
Uhu, filed #5111 for that. |
|
LGTM! This makes runner output not machine readable, but this is inteontional. Runner is an internal debugging tool, its not a public interface. Public interface for such things is https://github.com/near/sandbox nowdays. |
matklad
approved these changes
Nov 2, 2021
bowenwang1996
approved these changes
Nov 2, 2021
olonho
pushed a commit
that referenced
this pull request
Nov 4, 2021
VMOutcome is not serialized in rpc, only used in standalone as print result, which can be replaced by pretty print. Therefore, drop serialize/deserialize for VMOutcome Test Plan ------------ CI
pmnoxx
pushed a commit
that referenced
this pull request
Nov 20, 2021
VMOutcome is not serialized in rpc, only used in standalone as print result, which can be replaced by pretty print. Therefore, drop serialize/deserialize for VMOutcome Test Plan ------------ CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMOutcome is not serialized in rpc, only used in standalone as print result, which can be replaced by pretty print. Therefore, drop serialize/deserialize for VMOutcome
Test Plan
CI