nit(runtime): reinstall PartialEq on VMOutcome #5107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
requested review from
bowenwang1996,
EgorKulikov,
matklad,
mzhangmzz and
olonho
as code owners
4 tasks
bowenwang1996
approved these changes
Nov 2, 2021
Co-authored-by: Aleksey Kladov <[email protected]>
Co-authored-by: Aleksey Kladov <[email protected]>
|
has merge conflicts |
matklad
approved these changes
Nov 4, 2021
pmnoxx
pushed a commit
that referenced
this pull request
Nov 20, 2021
PartialEq was replaced by a custom impl to workaround comparison of vm_outcome_with_gas in test with different gas profile data. A better fix is only check gas used and do not use vm_outcome_with_gas. Only check gas used. Test Plan ------------ CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartialEq was replaced by a custom impl to workaround comparison of vm_outcome_with_gas in test with different gas profile data. A better fix is only check gas used and do not use vm_outcome_with_gas. Only check gas used.
Test Plan
CI