-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jsonrpc): updated rpc_errors_schema #5042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have contaxt, but looks fine to me.
Couple of questions there:
|
@matklad Why that error variant is not behind a feature-flag then? This file is used on near-api-js side to generate some "strictly typed errors" |
I'll add a check in CI that fails if there's a conflict in the schema
As far as I know, it's used in https://github.com/near/near-api-js/blob/ee975a1edd84dff955302453fbcca1413d362bb7/fetch_error_schema.js#L8, but so far, it's tagged to a specific revision - 4c11499, we can revise it before updating the file on that end. |
The code that produces error is gated, so gating the error variant itself isn't strictly necessary. Doing that is possible, it's just requires a bunch of extra cfgs everywhere. I and @Longarithm looked at that and figured that there's little benefit in that. No strong opinion on my side here though, could add a feature-gate there. |
Superseded by #5052 |
…re flag (#5052) Context: #5042 (comment) Hides the `TooManyFunctions` error variant behind a feature gate to avoid it leaking into the `rpc_errors_schema.json` dump.
Update
rpc_errors_schema.json
after the introduction ofTooManyFunctions
in #4954