refactor: use external crate for displaying tracing spans #4781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging #4771, I had to copy-paste tracing_timings module to get
a useful profiling output, which isn't ideal. So I improved and
published that code to crates.io as
tracing-span-tree
.In particular, this new implementation prints the trace in the correct
order, and it also has an
.aggregate(true)
mode for cases where yourun the profiled code in a loop and want a summary.
Example without aggregation:
Example with aggregation (unit-less number is the number of aggregated calls):
Test Plan
This is a debugging utility which is not enabled in production, so I just manually verified that the output makes sense.