fix: backport wasmer 0.17 FailWithNoError fix to master #4298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, we treated this error case as
deterministic (so, we stored this error in our state,
etc.)
Then, in
#4181 (comment)
we reasoned that this error actually happens
non-deterministically, so it's better to panic in this
case.
However, when rolling this out, we noticed that this
error happens deterministically for at least one
contract. So here we roll this back to a previous
behavior and emit some deterministic error, which won't
cause the node to panic.