Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport wasmer 0.17 FailWithNoError fix to master #4298

Merged
merged 2 commits into from
May 13, 2021

Conversation

matklad
Copy link
Contributor

@matklad matklad commented May 13, 2021

Initially, we treated this error case as
deterministic (so, we stored this error in our state,
etc.)

Then, in
#4181 (comment)
we reasoned that this error actually happens
non-deterministically, so it's better to panic in this
case.

However, when rolling this out, we noticed that this
error happens deterministically for at least one
contract. So here we roll this back to a previous
behavior and emit some deterministic error, which won't
cause the node to panic.

@matklad
Copy link
Contributor Author

matklad commented May 13, 2021

@olonho please take a look.

I am not really happy backporting this with a 🤷, but I don't see anything better we can do here.

Copy link
Contributor

@olonho olonho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, seems it's the best option we got.

@matklad
Copy link
Contributor Author

matklad commented May 13, 2021

Discussed during the contract runtime meeting, decided that this is the way to go.

@near-bulldozer near-bulldozer bot merged commit 9a121f4 into near:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants