fix: Fixing proxy_restart #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bowenwang1996
approved these changes
Sep 29, 2020
`start_proxy` starts a process that proxifies the node in the background, and immediatelly returns control to the main process. If the main process then kills the node, it sets `local_stopped` to 1. If `start_proxy` hasn't gotten to `check_finish` yet, `check_finish` will observe `local_stopped` set to 1, and stop the server. `start_proxy` will then proceed to calling `server.serve_forever`, which will crash. I'm fixing it by making `start_proxy` actually wait until it gets to `serve_forever` before returning control
SkidanovAlex
force-pushed
the
fix_proxy_restart
branch
from
ec4d23d to
a23893a
Compare
chefsale
pushed a commit
that referenced
this pull request
Oct 5, 2020
`start_proxy` starts a process that proxifies the node in the background, and immediatelly returns control to the main process. If the main process then kills the node, it sets `local_stopped` to 1. If `start_proxy` hasn't gotten to `check_finish` yet, `check_finish` will observe `local_stopped` set to 1, and stop the server. `start_proxy` will then proceed to calling `server.serve_forever`, which will crash. I'm fixing it by making `start_proxy` actually wait until it gets to `serve_forever` before returning control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_proxystarts a process that proxifies the node in thebackground, and immediatelly returns control to the main process.
If the main process then kills the node, it sets
local_stoppedto 1.If
start_proxyhasn't gotten tocheck_finishyet,check_finishwill observe
local_stoppedset to 1, and stop the server.start_proxywill then proceed to callingserver.serve_forever, whichwill crash.
I'm fixing it by making
start_proxyactually wait until it gets toserve_foreverbefore returning control