fix(runtime): use correct random value for random seed #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenwang1996
requested review from
ailisp,
evgenykuzyakov,
frol,
MaksymZavershynskyi,
olonho,
SkidanovAlex and
willemneal
as code owners
|
|
ailisp
reviewed
Aug 7, 2020
SkidanovAlex
approved these changes
Aug 7, 2020
ailisp
approved these changes
Aug 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #3096 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 212 212
Lines 42963 42963
=======================================
Hits 37762 37762
Misses 5201 5201 Continue to review full report at Codecov.
|
evgenykuzyakov
approved these changes
Aug 10, 2020
willemneal
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use action hash for the random seed, which is not random at all.
Test plan
upgradable.py.