-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removed duplicate and some useless optional dependencies #2520
Conversation
5318097
to
361bef8
Compare
361bef8
to
9f2a532
Compare
9f2a532
to
012de6a
Compare
@ailisp I had added the following command to the "sanity checks" step on CI: if [ -e deny.toml ]; then
wget "https://github.com/EmbarkStudios/cargo-deny/releases/download/$${CARGO_DENY_VERSION}/$${CARGO_DENY_PKG}.tar.gz"
tar xzf "$${CARGO_DENY_PKG}.tar.gz"
"$${CARGO_DENY_PKG}/cargo-deny" check bans
fi NOTE: I had to escape UPD: Can we include UPD2: Can we run pytest suite against PR? |
Do you want to run all of them? |
Yes but not very urgent as this step is usually faster than the other steps so speed up this step but does not increase the user wait time UPD2: Can we run pytest suite against PR? Plan to do that soon. currently how nightly run is not very ideal. My plan:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup! I was wondering how would different version of a crate coexist and the behave in the single neard binary
@ailisp Different versions of the same crate just have different symbol names like Some of the crates still are duplicated, but they are now explicitly whitelisted and documented in |
Well, this is a massive dependencies update, so I would rather catch problems in PR, than on master. Also, "nearlib test" was flaky on CI, so I just want to test it thoroughly, if possible. @ailisp Do we have a facility to trigger pytest manually? (I mean, I can start it running on my laptop, but I guess, that might take ages to finish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you!
tempdir
is deprecated since merge intotempfile
(I would not touch it would not it introduce the third version ofrand
crate into nearcore... we are stuck using two versions due to the epoch manager being rand-sensitive)deny.toml
config for the details about the whitelisted duplicates) to check for duplicate dependencies on CI (updated Buildkite pipeline); we may also use it to check licenses and advisoriesactix-http
uses 0.11 version