Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 2.4.0 CHANGELOG #12439

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Cut 2.4.0 CHANGELOG #12439

merged 2 commits into from
Nov 13, 2024

Conversation

staffik
Copy link
Contributor

@staffik staffik commented Nov 12, 2024

No description provided.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.43%. Comparing base (5ea595c) to head (e8dc7e1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12439   +/-   ##
=======================================
  Coverage   71.43%   71.43%           
=======================================
  Files         837      837           
  Lines      169401   169401           
  Branches   169401   169401           
=======================================
+ Hits       121005   121014    +9     
+ Misses      43044    43039    -5     
+ Partials     5352     5348    -4     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (ø)
db-migration 0.16% <ø> (ø)
genesis-check 1.29% <ø> (ø)
integration-tests 39.35% <ø> (+0.01%) ⬆️
linux 70.77% <ø> (+<0.01%) ⬆️
linux-nightly 70.99% <ø> (-0.01%) ⬇️
macos 51.02% <ø> (-0.01%) ⬇️
pytests 1.60% <ø> (ø)
sanity-checks 1.40% <ø> (ø)
unittests 63.97% <ø> (+<0.01%) ⬆️
upgradability 0.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


* Fixing invalid cost used for `wasm_yield_resume_byte`. [#12192](https://github.com/near/nearcore/pull/12192)
* Relaxing Congestion Control to allow accepting and buffering more transactions. [#12241](https://github.com/near/nearcore/pull/12241)
* Exclude contract code out of state witness and distribute it separately. [#11099](https://github.com/near/nearcore/issues/11099)
Copy link
Contributor

@tayfunelmas tayfunelmas Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a comment to this issue with a summary of the changes.
#11099 (comment)

Copy link
Contributor

@wacban wacban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated
### Protocol Changes

* Fixing invalid cost used for `wasm_yield_resume_byte`. [#12192](https://github.com/near/nearcore/pull/12192)
* Relaxing Congestion Control to allow accepting and buffering more transactions. [#12241](https://github.com/near/nearcore/pull/12241)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the second PR? The latter one overwrites the first one.

@@ -18,7 +33,6 @@
### Non-protocol Changes
* Added [documentation](./docs/misc/archival_data_recovery.md) and a [reference](./scripts/recover_missing_archival_data.sh) script to recover the data lost in archival nodes at the beginning of 2024.
* **Archival nodes only:** Stop saving partial chunks to `PartialChunks` column in the Cold DB. Instead, archival nodes will reconstruct partial chunks from the `Chunks` column.
* Decentralized state sync: Before, nodes that needed to download state (either because they're several epochs behind the chain or because they're going to start producing chunks for a shard they don't currently track) would download them from a centralized GCS bucket. Now, nodes will attempt to download pieces of the state from peers in the network, and only fallback to downloading from GCS if that fails. Please note that in order to participate in providing state parts to peers, your node may generate snapshots of the state. These snapshots should not take too much space, since they're hard links to database files that get cleaned up on every epoch.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VanBarbascu What was I supposed to put there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you already moved this part to 2.4.0.
In 2.3.0 we enebled state snapshots on every epoch to allow the nodes to take part in decentralized state sync.

@staffik staffik force-pushed the staffik-2.4-changelog branch from 09c5b72 to e8dc7e1 Compare November 13, 2024 19:10
@staffik staffik enabled auto-merge November 13, 2024 19:11
@staffik staffik added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 72c0aa9 Nov 13, 2024
29 checks passed
@staffik staffik deleted the staffik-2.4-changelog branch November 13, 2024 19:57
staffik added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants