Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple nearcore into a lib-crate #4233

Closed
frol opened this issue Apr 16, 2021 · 0 comments · Fixed by #4292
Closed

Decouple nearcore into a lib-crate #4233

frol opened this issue Apr 16, 2021 · 0 comments · Fixed by #4292
Assignees
@miraclx
Labels
C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@frol
Copy link
Collaborator

frol commented Apr 16, 2021

As part of the bigger initiative #1881, we want to break neard crate into two:

  • neard binary
  • nearcore library

We use neard as a library in Indexer Framework, and it might also improve testability and maintainability. This will also lay a path towards better dependencies handling.
@frol frol added the C-housekeeping Category: Refactoring, cleanups, code quality label Apr 16, 2021
@miraclx miraclx mentioned this issue May 10, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue May 27, 2021
@miraclx
refactor(neard): decouple into individual crates (#4292)
7d16cf5 
Dissociates `neard` into its binary and library constituents, with the binary depending on the library. Fixes #4233.

The intent is to have the binary named `neard` and the library named `nearcore`. However, because the workspace is itself `nearcore`, we can either move the library into the root or use a different name for either the workspace or the library itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miraclx miraclx

Labels
C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(neard): decouple into individual crates miraclx/nearcore
2 participants
@frol @miraclx