Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC python tests are flaky #3133

Closed
SkidanovAlex opened this issue Aug 11, 2020 · 1 comment · Fixed by #3160
Closed

GC python tests are flaky #3133

SkidanovAlex opened this issue Aug 11, 2020 · 1 comment · Fixed by #3160
Assignees
@bowenwang1996
Labels
A-chain Area: Chain, client & related

Comments

@SkidanovAlex
Copy link
Collaborator

Often fail with connection refused, e.g:

gc_after_sync.py (connection refused):
http://52.149.162.182:3000/#/test/7746
http://52.149.162.182:3000/#/test/7626

gc_after_sync1.py (rpc timeout)
http://52.149.162.182:3000/#/test/4627

gc_sync_after_sync.py (connection refused):
http://52.149.162.182:3000/#/test/7748
http://52.149.162.182:3000/#/test/7628
http://52.149.162.182:3000/#/test/7508
@SkidanovAlex SkidanovAlex added the A-chain Area: Chain, client & related label Aug 11, 2020
@SkidanovAlex
Copy link
Collaborator Author

gc_sync_after_sync.py started consistently failing after 9ca3117

Assigning to Bowen.

@bowenwang1996 bowenwang1996 mentioned this issue Aug 13, 2020
Merged
bowenwang1996 added a commit that referenced this issue Aug 13, 2020
@bowenwang1996
fix(test): gc_sync_after_sync (#3160)
c9d37cf 
gc_sync_after_sync_* tests fail for the following reasons:
1) fork_tail is not properly maintained. A node resets fork tail after state sync but we allowed it to go back on epoch change.
2) in #3099 I didn't account for the fact that we can have chunk in storage whose height is higher than the current head.

Fixes #3133.

Test plan
----------
Run each of the gc_sync_after_sync_* tests 30 tests and observe that there is 0 failure.
@weekly-digest weekly-digest bot mentioned this issue Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bowenwang1996 bowenwang1996

Labels
A-chain Area: Chain, client & related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(test): gc_sync_after_sync near/nearcore
2 participants
@SkidanovAlex @bowenwang1996