Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_simple_transfer fails #2992

Closed
frol opened this issue Jul 15, 2020 · 2 comments · Fixed by #3027
Closed

test_simple_transfer fails #2992

frol opened this issue Jul 15, 2020 · 2 comments · Fixed by #3027
Assignees
@evgenykuzyakov
Labels
C-bug Category: This is a bug

Comments

@frol
Copy link
Collaborator

frol commented Jul 15, 2020

Describe the bug

CI seems to fail due to a flacky test:

[2020-07-15T13:56:07Z] ---- test_simple_transfer stdout ----
[2020-07-15T13:56:07Z] thread 'test_simple_transfer' panicked at 'index out of bounds: the len is 0 but the index is 0', runtime/runtime/tests/test_async_calls.rs:589:5

https://buildkite.com/nearprotocol/nearcore/builds/2552#d060f247-329f-4a2c-a0ca-4d86717851ac/6-3794

To Reproduce

Unknown

Expected behavior

The test should pass.

Version (please complete the following information):
@frol frol added the C-bug Category: This is a bug label Jul 15, 2020
@weekly-digest weekly-digest bot mentioned this issue Jul 17, 2020
Closed
@evgenykuzyakov
Copy link
Collaborator

Hmm. This might be due to random fees. I wonder what fee triggers it.

@frol
Copy link
Collaborator Author

frol commented Jul 22, 2020

Failed again on a PR which just updates a README (#2997) file: https://buildkite.com/nearprotocol/nearcore/builds/2643#249b8945-fbf1-41b6-b2f1-1530c46a0a9f/6-3932

@evgenykuzyakov evgenykuzyakov mentioned this issue Jul 23, 2020
Merged
nearprotocol-bulldozer bot pushed a commit that referenced this issue Jul 24, 2020
fix: Fix flaky test (#3027)
dc2bc38 
The test was not generating a refund receipt because there were no pessimistic inflation 1 in 10 times.
Also removing some dead code from the macro.

Fixes: #2992

# Test plan:
- CI
- Verified the test fails when inflation is `1.0` and doesn't when it's higher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgenykuzyakov evgenykuzyakov

Labels
C-bug Category: This is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix flaky test near/nearcore
2 participants
@frol @evgenykuzyakov