chore: suppress sandbox bin logs #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
reviewed
Mar 4, 2022
workspaces/src/network/server.rs
Outdated
Comment on lines
80
to
81
| match std::env::var("NEAR_ENABLE_SANDBOX_LOG") { | ||
| Ok(val) if val == "on" => {} |
There was a problem hiding this comment.
why not just require the env variable to be set? is the on pattern documented somewhere?
There was a problem hiding this comment.
I agree, the usual convention is either set/unset or 1/0
There was a problem hiding this comment.
Ahh, will switch to just set/unset. Way too use to cmake flags so a force of habit
austinabell
approved these changes
Mar 4, 2022
miraclx
reviewed
Mar 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suppresses all sandbox logs and allows the user to control it via an environment variable