Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.1.1 #59

Merged
merged 3 commits into from
Jan 24, 2022
Merged

release: 0.1.1 #59

merged 3 commits into from
Jan 24, 2022

Conversation

ChaoticTempest
Copy link
Member

Cutting a patch version release on top of #46 so that it doesn't stall CI for some projects like near-sdk-rs. This won't have any API breaking changes, so should be fine making this a patch version release

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes with API breaking changes, so can't do as a patch release unless you release without #52.

Would releasing near/near-sandbox#21 as a patch release for sandbox be sufficient to fix this?

@ChaoticTempest
Copy link
Member Author

@austinabell yeah, I'm going to be releasing it on top of the commit of #46 which doesn't have #52

Would releasing near/near-sandbox#21 as a patch release for sandbox be sufficient to fix this?

that's a good point, and yes it should. We can skip this release then since workspaces uses near-sandbox-utils = "0.1"

@austinabell
Copy link
Contributor

austinabell commented Jan 20, 2022

@austinabell yeah, I'm going to be releasing it on top of the commit of #46 which doesn't have #52

Oops I misread you comment, that works!

that's a good point, and yes it should. We can skip this release then since workspaces uses near-sandbox-utils = "0.1"

Well, in this patch release we can bump the sandbox utils dep to 0.1.1 to ensure the previous isn't used?

@ChaoticTempest
Copy link
Member Author

Well, in this patch release we can bump the sandbox utils dep to 0.1.1 to ensure the previous isn't used?

hmm, I see yeah. Cargo could cache 0.1.0 right? Specifically for projects that are already using 0.1.0? Then best to be explicit here then

- Bugfix for installing binaries
@austinabell
Copy link
Contributor

Well, in this patch release we can bump the sandbox utils dep to 0.1.1 to ensure the previous isn't used?

hmm, I see yeah. Cargo could cache 0.1.0 right? Specifically for projects that are already using 0.1.0? Then best to be explicit here then

If you use 0.1.1 that sets the minimum and would update that dependency if 0.1.0 is cached. That's the reason for setting this minimum. Doesn't really matter either way I don't think in this case.

Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ChaoticTempest ChaoticTempest merged commit 0d33fe5 into main Jan 24, 2022
@ChaoticTempest ChaoticTempest deleted the release/0.1.1 branch January 24, 2022 18:40
@frol frol mentioned this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants