-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.1.1 #59
release: 0.1.1 #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes with API breaking changes, so can't do as a patch release unless you release without #52.
Would releasing near/near-sandbox#21 as a patch release for sandbox be sufficient to fix this?
@austinabell yeah, I'm going to be releasing it on top of the commit of #46 which doesn't have #52
that's a good point, and yes it should. We can skip this release then since workspaces uses |
Oops I misread you comment, that works!
Well, in this patch release we can bump the sandbox utils dep to 0.1.1 to ensure the previous isn't used? |
hmm, I see yeah. Cargo could cache 0.1.0 right? Specifically for projects that are already using 0.1.0? Then best to be explicit here then |
- Bugfix for installing binaries
If you use 0.1.1 that sets the minimum and would update that dependency if 0.1.0 is cached. That's the reason for setting this minimum. Doesn't really matter either way I don't think in this case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Cutting a patch version release on top of #46 so that it doesn't stall CI for some projects like
near-sdk-rs
. This won't have any API breaking changes, so should be fine making this a patch version release