release: 0.4.0 #170
Merged
release: 0.4.0 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, after recent additions, the macOS tests seems to be pretty non-deterministic these days... I'll have to test this later, but it does seem like the instance of macOS GH has is really slow since it takes hours to publish the binaries in nearcore |
austinabell
approved these changes
Jul 20, 2022
| - `Debug`/`Clone` impls for `Account`/`Contract`, and `Debug` for `Worker`: https://github.com/near/workspaces-rs/pull/167 | ||
| - `ExecutionOutcome::tokens_burnt` is now available: https://github.com/near/workspaces-rs/pull/168 | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
Should we also indicate that the default sandbox version has changed?
austinabell
suggested changes
Jul 21, 2022
There was a problem hiding this comment.
having an issue compiling with near-crypto 0.14 on ubuntu:
error[E0599]: no function or associated item named `from_bytes` found for struct `ed25519_dalek::Signature` in the current scope
--> /home/austinabell/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/near-crypto-0.14.0/src/test_utils.rs:59:62
|
59 | Signature::ED25519(ed25519_dalek::Signature::from_bytes(&SIG).unwrap())
| ^^^^^^^^^^ function or associated item not found in `ed25519_dalek::Signature`
looking through docs the method doesn't exist, so not sure where this is referenced. Potentially missing a feature?
austinabell
approved these changes
Jul 21, 2022
|
disabling the macos-latest test target since we can resolve that later |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will do a release after this.