release: 0.2 #104
release: 0.2 #104
Conversation
Co-authored-by: Austin Abell <[email protected]>
Co-authored-by: Austin Abell <[email protected]>
README.md
Outdated
| ## Testing | ||
| A simple test to get us going and familiar with the features: | ||
| ### Note about compiling with contract | ||
| `workspaces-rs` does not currently support compiling to WASM. So, if we are compiling this library alongside a `wasm32` target such as compiling alongside a NEAR contract, it is best if we put this dependency in `[dev-dependencies]` section to avoid any conflicts. |
There was a problem hiding this comment.
Discussed in chat. But I initially read this as a reference to the contract code being complied rather than workspaces itself
There was a problem hiding this comment.
@doriancrutcher @AustinBaggio should look better now
| ```toml | ||
| # Cargo.toml | ||
| [dependencies] | ||
| workspaces = "*" |
There was a problem hiding this comment.
Why are we showing an example of a broken pattern in the readme?
There was a problem hiding this comment.
Just trying to show the dichotomy of how it'd look like if it didn't work vs the working example. Any suggestions to make it better or to reword it?
There was a problem hiding this comment.
This just seems like something relating to the SDK. I feel like if we just share that it does not compile to wasm with some information about that would be sufficient, rather than showing an example of workspaces being included in the SDK dependencies (which it should never be).
Opinionated so nothing has to change, just sharing thoughts that it might be confusing to someone reading
There was a problem hiding this comment.
I see, yeah that's a good point. I still mentioned the SDK since that seems to be the most common case people would hit from what I've seen. Added the fix here: #115
No description provided.